tests: crypto: tinycrypt: Fix premature Ztest end logging #80793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use TC_END_RESULT() to report Ztest's result prematurely. Signed-off-by: Dmitrii Golovanov <[email protected]>
golowanow
changed the title
ceolin
approved these changes
Nov 7, 2024
nashif
approved these changes
Nov 7, 2024
Contributor
|
@golowanow @nashif @ceolin , is this needed for 4.0? |
Contributor
@mmahadevan108 I'd say yes as Tinycrypt is not deprecated in 4.0 and tests can be fixed/merged. |
dkalowsk
approved these changes
Nov 8, 2024
Member
Even if it was deprecated, makes sense to me to keep tests until it is completely removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use TC_END_RESULT() to report Ztest's result prematurely.